From 707ac94e49b155a31552439db8e0e9a1ced3bbda Mon Sep 17 00:00:00 2001 From: Dave Russell <39733752+007revad@users.noreply.github.com> Date: Mon, 22 Jan 2024 21:48:01 +1100 Subject: [PATCH 1/4] Update CHANGES.txt --- CHANGES.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGES.txt b/CHANGES.txt index 57a527e..ab25054 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,3 +1,6 @@ +v3.4.82 +- Fix for drives that exist in the drive database already but have "compatibility unverified". Issue #224 + v3.4.81 - Bug fix for false "This script is NOT running on a Synology NAS!" if uname is installed from Entware. Issue #218 From d908461a80808726260fd8a7af88eedeb1635222 Mon Sep 17 00:00:00 2001 From: Dave Russell <39733752+007revad@users.noreply.github.com> Date: Mon, 22 Jan 2024 21:48:17 +1100 Subject: [PATCH 2/4] Update syno_hdd_db.sh --- syno_hdd_db.sh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/syno_hdd_db.sh b/syno_hdd_db.sh index 9524b44..76bca9b 100644 --- a/syno_hdd_db.sh +++ b/syno_hdd_db.sh @@ -27,7 +27,7 @@ # Now warns if script is located on an M.2 volume. -scriptver="v3.4.81" +scriptver="v3.4.82" script=Synology_HDD_db repo="007revad/Synology_HDD_db" scriptname=syno_hdd_db @@ -1114,6 +1114,9 @@ editdb7(){ #exit 6 fi fi + + # Edit existing drives in db with compatibility:unverified # Issue #224 + sed -i 's/unverified/support/g' "$2" } From aad502c217304f9eb00222822c99f29f039e2a15 Mon Sep 17 00:00:00 2001 From: Dave Russell <39733752+007revad@users.noreply.github.com> Date: Tue, 23 Jan 2024 06:01:40 +1100 Subject: [PATCH 3/4] Update syno_hdd_db.sh - Fix for drives that exist in the drive database already but have "compatibility unverified". Issue #224 --- syno_hdd_db.sh | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/syno_hdd_db.sh b/syno_hdd_db.sh index 76bca9b..bea4028 100644 --- a/syno_hdd_db.sh +++ b/syno_hdd_db.sh @@ -1114,9 +1114,6 @@ editdb7(){ #exit 6 fi fi - - # Edit existing drives in db with compatibility:unverified # Issue #224 - sed -i 's/unverified/support/g' "$2" } @@ -1163,6 +1160,14 @@ updatedb(){ editdb7 "append" "$2" fi fi + + # Edit existing drives in db with compatibility:unverified # Issue #224 + if grep 'unverified' "$2" >/dev/null; then + sed -i 's/unverified/support/g' "$2" + if ! grep 'unverified' "$2" >/dev/null; then + echo -e "Edited unverified drives in ${Cyan}$(basename -- "$2")${Off}" >&2 + fi + fi elif [[ $dbtype -eq "6" ]]; then if grep "$hdmodel" "$2" >/dev/null; then echo -e "${Yellow}$hdmodel${Off} already exists in ${Cyan}$(basename -- "$2")${Off}" >&2 From e715b62565909098f213df0f5d708773afb377da Mon Sep 17 00:00:00 2001 From: Dave Russell <39733752+007revad@users.noreply.github.com> Date: Tue, 23 Jan 2024 06:04:21 +1100 Subject: [PATCH 4/4] Update syno_hdd_db.sh fix comment typo --- syno_hdd_db.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/syno_hdd_db.sh b/syno_hdd_db.sh index bea4028..4819451 100644 --- a/syno_hdd_db.sh +++ b/syno_hdd_db.sh @@ -1798,7 +1798,7 @@ fi setting="$(get_key_value $synoinfo support_wdda)" if [[ $wdda == "no" ]]; then if [[ $setting == "yes" ]]; then - # Disable support_memory_compatibility + # Disable support_wdda synosetkeyvalue "$synoinfo" support_wdda "no" setting="$(get_key_value "$synoinfo" support_wdda)" if [[ $setting == "no" ]]; then