From 48a65a9866fdc4be72a7e5c11475c2d96e719b64 Mon Sep 17 00:00:00 2001
From: Dave Russell <39733752+007revad@users.noreply.github.com>
Date: Wed, 3 Apr 2024 15:37:15 +1100
Subject: [PATCH 1/2] Update syno_hdd_db.sh

Changed how memory compatibility is disabled for older models. Issue #272
---
 syno_hdd_db.sh | 50 +++++++++++++++++++++++++++++++++++++-------------
 1 file changed, 37 insertions(+), 13 deletions(-)

diff --git a/syno_hdd_db.sh b/syno_hdd_db.sh
index 02afe31..66def20 100644
--- a/syno_hdd_db.sh
+++ b/syno_hdd_db.sh
@@ -16,6 +16,8 @@
 #--------------------------------------------------------------------------------------------------
  
 # CHANGES
+# Changed disabling memory compatibility for older models. Issue #272
+#
 # Hard coded /usr/syno/bin/<command> for Synology commands (to prevent $PATH issues).
 #
 # Now enables creating storage pools in Storage Manager for M.2 drives in PCIe adaptor cards.
@@ -35,7 +37,7 @@
 # /var/packages/StorageManager/target/ui/storage_panel.js
 
 
-scriptver="v3.4.87"
+scriptver="v3.5.88"
 script=Synology_HDD_db
 repo="007revad/Synology_HDD_db"
 scriptname=syno_hdd_db
@@ -1620,10 +1622,40 @@ else
 fi
 
 
-# Optionally disable "support_memory_compatibility" (not for DVA models)
-if [[ ${model:0:3} != "dva" ]]; then
-    smc=support_memory_compatibility
-    setting="$(/usr/syno/bin/synogetkeyvalue $synoinfo $smc)"
+# Optionally disable memory compatibility warnings
+smc=support_memory_compatibility
+setting="$(/usr/syno/bin/synogetkeyvalue $synoinfo $smc)"
+settingbak="$(/usr/syno/bin/synogetkeyvalue $synoinfo.bak $smc)"
+
+if [[ -z $settingbak ]] || [[ -z $setting ]]; then
+    # For older models that don't use "support_memory_compatibility"
+    memcheck="/usr/lib/systemd/system/SynoMemCheck.service"
+    memcheck_value="$(/usr/syno/bin/synosetkeyvalue "$memcheck" ExecStart)"
+    if [[ $ram == "yes" ]]; then
+        if [[ $memcheck_value == "/usr/syno/bin/syno_mem_check" ]]; then
+            # Disable SynoMemCheck.service
+            /usr/syno/bin/synosetkeyvalue "$memcheck" ExecStart /bin/true
+            memcheck_value="$(/usr/syno/bin/synosetkeyvalue "$memcheck" ExecStart)"
+            if [[ $memcheck_value == "/bin/true" ]]; then
+                echo -e "\nDisabled SynoMemCheck memory compatibility."
+            fi
+        elif [[ $memcheck_value == "/bin/true" ]]; then
+            echo -e "\nSynoMemCheck memory compatibility already disabled."
+        fi
+    else
+        if [[ $memcheck_value == "/bin/true" ]]; then
+            # Enable SynoMemCheck.service
+            /usr/syno/bin/synosetkeyvalue "$memcheck" ExecStart /usr/syno/bin/syno_mem_check
+            memcheck_value="$(/usr/syno/bin/synosetkeyvalue "$memcheck" ExecStart)"
+            if [[ $memcheck_value == "/usr/syno/bin/syno_mem_check" ]]; then
+                echo -e "\nRe-enabled SynoMemCheck memory compatibility."
+            fi
+        elif [[ $memcheck_value == "/usr/syno/bin/syno_mem_check" ]]; then
+            echo -e "\nSynoMemCheck memory compatibility already enabled."
+        fi
+    fi
+else
+    # Disable "support_memory_compatibility" (not for older models)
     if [[ $ram == "yes" ]]; then
         if [[ $setting == "yes" ]]; then
             # Disable support_memory_compatibility
@@ -1649,14 +1681,6 @@ if [[ ${model:0:3} != "dva" ]]; then
     fi
 fi
 
-# Disable SynoMemCheck.service for DVA models
-if [[ ${model:0:3} == "dva" ]]; then
-    memcheck="/usr/lib/systemd/system/SynoMemCheck.service"
-    if [[ $(/usr/syno/bin/synogetkeyvalue "$memcheck" ExecStart) == "/usr/syno/bin/syno_mem_check" ]]; then
-        /usr/syno/bin/synosetkeyvalue "$memcheck" ExecStart /bin/true
-    fi
-fi
-
 # Optionally set mem_max_mb to the amount of installed memory
 if [[ $dsm -gt "6" ]]; then  # DSM 6 as has no dmidecode
     if [[ $ram == "yes" ]] && [[ -f /usr/sbin/dmidecode ]]; then

From 39d3362a66505da34b4d2790682f346dbb46ba75 Mon Sep 17 00:00:00 2001
From: Dave Russell <39733752+007revad@users.noreply.github.com>
Date: Wed, 3 Apr 2024 15:38:11 +1100
Subject: [PATCH 2/2] Update CHANGES.txt

---
 CHANGES.txt | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/CHANGES.txt b/CHANGES.txt
index 4af6356..14b8151 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,3 +1,6 @@
+v3.5.88
+- Changed how memory compatibility is disabled for older models. Issue #272
+
 v3.4.87
 - Fix Invalid json format syslog output #270