From df9ec99d61bdfc87824fc87f099e74bc2a4ace20 Mon Sep 17 00:00:00 2001 From: 007revad <39733752+007revad@users.noreply.github.com> Date: Tue, 23 Jun 2026 13:53:48 +1000 Subject: [PATCH] v3.6.132 --- CHANGES.txt | 3 +++ syno_hdd_db.sh | 13 +++++++++---- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/CHANGES.txt b/CHANGES.txt index 35588a1..dcdea35 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -2,6 +2,9 @@ v3.6.132 - Bug fix for expansion units that DSM reports with different model names. Issue #578 - Adds aliases from each expansion disk's runtime container, such as mapping RX1217-1 to RX1217 when detection reports RX1217RP. - Uses exact model-family matching so RX1217 does not also edit RX1217RP or RX1217SAS database files. +- Bug fix for trying to backup non-existent file. Issue #578 +- Bug fix for SynoOnlinePack version not found. + Thanks @tkirkland v3.6.131 diff --git a/syno_hdd_db.sh b/syno_hdd_db.sh index 1586a6d..048895a 100644 --- a/syno_hdd_db.sh +++ b/syno_hdd_db.sh @@ -29,7 +29,7 @@ # /var/packages/StorageManager/target/ui/storage_panel.js -scriptver="v3.6.131" +scriptver="v3.6.132" script=Synology_HDD_db repo="007revad/Synology_HDD_db" scriptname=syno_hdd_db @@ -342,9 +342,13 @@ if [[ $dsmversion -gt "72" ]]; then else SOPinfo="/var/packages/SynoOnlinePack/INFO" fi - SOPpkgver="$(/usr/syno/bin/synogetkeyvalue $SOPinfo version)" - #echo -e "SynoOnlinePack$v2 version $SOPpkgver\n" - echo "- SynoOnlinePack$v2 version $SOPpkgver" + if [[ -f "$SOPinfo" ]]; then + SOPpkgver="$(/usr/syno/bin/synogetkeyvalue $SOPinfo version)" + #echo -e "SynoOnlinePack$v2 version $SOPpkgver\n" + echo "- SynoOnlinePack$v2 version $SOPpkgver" + else + echo "- SynoOnlinePack$v2 version not found" + fi #else # echo "" fi @@ -1457,6 +1461,7 @@ getdbtype(){ backupdb(){ # Backup database file if needed local bakversion newversion fname + [[ -z "$1" || ! -f "$1" ]] || return 0 # Don't try to backup non-existent files if [[ $2 == "long" ]]; then fname="$1" else