From 7f00728a98083e1a121be79c59e9c43d7fd0c382 Mon Sep 17 00:00:00 2001 From: Raimund Andree Date: Mon, 5 Oct 2026 02:19:09 +0200 Subject: [PATCH] chore(memory-bank): record group D Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: AI Assistant --- .memory-bank/activeContext.md | 22 ++++++++++++++-------- .memory-bank/progress.md | 4 +++- 2 files changed, 17 insertions(+), 9 deletions(-) diff --git a/.memory-bank/activeContext.md b/.memory-bank/activeContext.md index 915ec7e..609b3fd 100644 --- a/.memory-bank/activeContext.md +++ b/.memory-bank/activeContext.md @@ -42,16 +42,22 @@ the PRs, and tags `5.0.0-rc2` after the merges. Review: Dependabot PRs ran unreviewed actions in a job with `contents: write`; the wiki preview is now read-only (`publish-wiki`). - `ai/defects-a` fixes defects 1 to 13 and the same repeat bug in - `Get-NTFSAccess` (found with 4): Windows PowerShell 310 passed, 17 - skipped; PowerShell 7 280 passed, 47 skipped (327 tests). 10 tests need - privileges and run only in CI. + `Get-NTFSAccess` (found with 4); its review fixes are in the last + commit: Windows PowerShell 312 passed, 17 skipped; PowerShell 7 282 + passed, 47 skipped (329 tests). - `ai/defects-b` fixes defects 14 to 17 (`-AppliesTo` is mandatory in the - `Simple` sets; `-RemoveSpecific` is back): Windows PowerShell 331 passed, - 19 skipped; PowerShell 7 301 passed, 49 skipped (350 tests). + `Simple` sets; `-RemoveSpecific` is back): Windows PowerShell 333 passed, + 19 skipped; PowerShell 7 303 passed, 49 skipped (352 tests). - `ai/defects-c` fixes defects 18 to 21, the same missing `continue` in - `Remove-NTFSAudit`, and a stale hash in `Get-FileHash2`. + `Remove-NTFSAudit`, and a stale hash in `Get-FileHash2`. Its review + found that a failed retry after taking ownership left the owner changed; + `BaseCmdlet.InvokeAsOwner` now restores it: Windows PowerShell 356 + passed, 20 skipped; PowerShell 7 325 passed, 51 skipped (376 tests). +- `ai/defects-d` fixes defects 22 to 24 and `-PassThru` under `-WhatIf` in + the `*-Item2` cmdlets: Windows PowerShell 379 passed, 23 skipped; + PowerShell 7 348 passed, 54 skipped (402 tests). ## Next step -Group D (22 to 24) on `ai/defects-d`, then the E decisions and the bugs -from the issue triage (`ai/issue-fixes`). +The E decisions on `ai/decisions-e` (Decision 13 for `Set-NTFSInheritance`), +then the bugs from the issue triage (`ai/issue-fixes`) and 5.0.0-rc2. diff --git a/.memory-bank/progress.md b/.memory-bank/progress.md index bba0bb4..c3a08e7 100644 --- a/.memory-bank/progress.md +++ b/.memory-bank/progress.md @@ -154,7 +154,7 @@ Numbered as agreed with the maintainer; each is documented on its page. after a failed change, and a failed retry after taking ownership left the owner changed; `BaseCmdlet.InvokeAsOwner` now restores it on every path. -#### D: Metadata and cosmetics +#### D: Metadata and cosmetics (fixed on `ai/defects-d`, not merged) - (22) Wrong or missing `[OutputType]` (`Test-Path2`, `Get-FileHash2`, `Add-NTFSAudit`, `*-Item2`, inheritance cmdlets); @@ -163,6 +163,8 @@ Numbered as agreed with the maintainer; each is documented on its page. - (23) Typos: "Privliege" in the `Get-NTFSEffectiveAccess` warning; "are now enabled" in the `Disable-Privileges` verbose message. - (24) Dead code in `RemoveItem2.cs` and `OtherCmdlets.cs`. +- Found with group D: `-PassThru` of the `*-Item2` cmdlets wrote the item + also when `-WhatIf` skipped the operation. #### E: Maintainer decisions before changing behavior