Compare commits

...

2 Commits

Author SHA1 Message Date
Dave Russell b095f29ed7
Update script version and enhance whitespace handling 2 days ago
Dave Russell ca75ef2dbc
Update CHANGES.txt for version 3.6.122 2 days ago
  1. 4
      CHANGES.txt
  2. 11
      syno_hdd_db.sh

4
CHANGES.txt

@ -1,3 +1,7 @@
v3.6.122
- Bug fix for drive models with multiple consecutive spaces in model name. Issue #559
- Bug fix for nvme drives with multiple consecutive spaces in firmware version.
v3.6.121 v3.6.121
- Added --reboot option to reboot the NAS after a DSM update where the build number has changed. - Added --reboot option to reboot the NAS after a DSM update where the build number has changed.
- Only needed if NVMe volume or PCIe card need a 2nd reboot after DSM update. - Only needed if NVMe volume or PCIe card need a 2nd reboot after DSM update.

11
syno_hdd_db.sh

@ -29,7 +29,7 @@
# /var/packages/StorageManager/target/ui/storage_panel.js # /var/packages/StorageManager/target/ui/storage_panel.js
scriptver="v3.6.121" scriptver="v3.6.122"
script=Synology_HDD_db script=Synology_HDD_db
repo="007revad/Synology_HDD_db" repo="007revad/Synology_HDD_db"
scriptname=syno_hdd_db scriptname=syno_hdd_db
@ -1026,7 +1026,8 @@ getdriveinfo(){
# Get drive model # Get drive model
hdmodel=$(cat "$1/device/model") hdmodel=$(cat "$1/device/model")
hdmodel=$(printf "%s" "$hdmodel" | xargs) # trim leading and trailing white space #hdmodel=$(printf "%s" "$hdmodel" | xargs) # trim leading and trailing white space (also replaces multiple spaces in model with 1 space)
hdmodel="$(printf "%s" "$hdmodel" | sed 's/^[[:space:]]*//;s/[[:space:]]*$//')" # trim leading and trailing white space
# Fix dodgy model numbers # Fix dodgy model numbers
fixdrivemodel "$hdmodel" fixdrivemodel "$hdmodel"
@ -1066,13 +1067,15 @@ getdriveinfo(){
getm2info(){ getm2info(){
# $1 is /sys/block/nvme0n1 etc # $1 is /sys/block/nvme0n1 etc
nvmemodel=$(cat "$1/device/model") nvmemodel=$(cat "$1/device/model")
nvmemodel=$(printf "%s" "$nvmemodel" | xargs) # trim leading and trailing white space #nvmemodel=$(printf "%s" "$nvmemodel" | xargs) # trim leading and trailing white space (also replaces multiple spaces in model with 1 space)
nvmemodel="$(printf "%s" "$nvmemodel" | sed 's/^[[:space:]]*//;s/[[:space:]]*$//')" # trim leading and trailing white space
if [[ $2 == "nvme" ]]; then if [[ $2 == "nvme" ]]; then
nvmefw=$(cat "$1/device/firmware_rev") nvmefw=$(cat "$1/device/firmware_rev")
elif [[ $2 == "nvc" ]]; then elif [[ $2 == "nvc" ]]; then
nvmefw=$(cat "$1/device/rev") nvmefw=$(cat "$1/device/rev")
fi fi
nvmefw=$(printf "%s" "$nvmefw" | xargs) # trim leading and trailing white space #nvmefw=$(printf "%s" "$nvmefw" | xargs) # trim leading and trailing white space (also replaces multiple spaces in model with 1 space)
nvmefw="$(printf "%s" "$nvmefw" | sed 's/^[[:space:]]*//;s/[[:space:]]*$//')" # trim leading and trailing white space
# Get drive GB size # Get drive GB size
size_gb=$(get_size_gb "$1") size_gb=$(get_size_gb "$1")

Loading…
Cancel
Save